Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully-qualified image names #862

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Conversation

edsantiago
Copy link
Collaborator

Replace shortnames with FQINs; this should allow tests to
run regardless of the state of registries.conf.

And, fix one broken new test that invoked 'jq' (without dot).
This usage works in Fedora, but not in RHEL.

Signed-off-by: Ed Santiago santiago@redhat.com

Replace shortnames with FQINs; this should allow tests to
run regardless of the state of registries.conf.

And, fix one broken new test that invoked 'jq' (without dot).
This usage works in Fedora, but not in RHEL.

Signed-off-by: Ed Santiago <santiago@redhat.com>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

systemtest/020-copy.bats Show resolved Hide resolved
@mtrmac
Copy link
Collaborator

mtrmac commented Mar 19, 2020

(FWIW I keep a few more edits to these tests to make them work on CentOS 7 in #46 . That PR is probably going to stay WIP for a while, are those individual parts useful anyway?)

@edsantiago
Copy link
Collaborator Author

@mtrmac the jq . one should no longer be necessary after this merges. The IFS I find puzzling but can't look at in depth right now. My first guess is that your system has a too-old version of BATS? Are you using >= 1.0 ?

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 19, 2020

@mtrmac the jq . one should no longer be necessary after this merges.

Yes.

The IFS I find puzzling but can't look at in depth right now. My first guess is that your system has a too-old version of BATS? Are you using >= 1.0 ?

Yes, CentOS has (had?) a rather old version, this works around a bug that has long been fixed.

CentOS, as of bats-0.4.0-1.20141016git3b33a5a.el7.noarch, misses the fix for sstephenson/bats#89 , causing (read) not to split words at white space.

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 19, 2020

I was just pointing out the other change in case it were relevant to your other work. If this is only targeting 8, it’s probably not necessary.

@mtrmac mtrmac merged commit 12865fd into containers:master Mar 19, 2020
@edsantiago edsantiago deleted the registry_fqin branch March 19, 2020 21:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants