WIP: Add support for (make check CHECK_BASE_IMAGES='fedora centos')

[mtrmac]

This is intended for use in Travis, modifying the make check command to the above (but running this locally would of course also be possible). The default behavior remains the same, uses the fedora image.

At the moment, this does not work because in centos, the python-pip package is not available (perhaps in EPEL?).

(Also note that the (yum install) does not fail when one of the packages is missing.)

Anyone, feel free to take this over (adding conditionals to Dockerfiles? Maintaining a Dockerfile.fedora and Dockerfile.centos separately?) if you have the time.

[cgwalters]

FYI, my work in CentOS CI on PR testing is now triggering for skopeo.

It chains into rpmdistro-gitoverlay (i.e. it's building the way we're shipping). See
https://github.com/cgwalters/sig-atomic-buildscripts/blob/ebd950bf686b54cfdca49dfca2a305a4363cc2cd/centos-ci/jjb/sig-atomic-testing.yml#L190

I'll post more about this when it's farther along.

It might be worth looking at how rpmdistro-gitoverlay works, as I'd like it to be a convenient tool for local development too. (It's a bit away from that now, but it also has fundamental architectural advantages over Dockerfile per repo)

[mtrmac]

OK, this now seems to work (but, man, the compile-test-debug-edit cycle with Dockerfiles is long); except that it correctly diagnoses #89 and breaks the build. So, trying with #91 to see whether that would be enough.

[mtrmac]

Fixed up, everything seems to work per #91. Note that on CentOS we don't run golint because it does not build against Go 1.4.2.

I will keep rebasing this and #91 from time to time, so that we have a chance to know about CentOS failures before Colin finds out ☺

[rhatdan]

3.5 years since this has been updated? Should we close?

[mtrmac]

Last updated less than a month ago, actually.

I’d love for this to be integrated in some sort of CI (and for the CI not to spend >15 minutes building OpenShift 1.5 every single time), but this is still better than nothing.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[cevich]

IMHO this PR should indeed be closed, it's no-longer relevant nor applicable given the amount of changes on the CI side. Downstream consumers need to have their own environment-independent test-suites. If those can reasonably be shared with upstream (i.e. like how we have a separate system-tests package for podman) that's fine. But it's unworkable to hold-back upstream development based on downstream (i.e. necessarily "old") environment requirements.

[mtrmac]

But it's unworkable to hold-back upstream development based on downstream (i.e. necessarily "old") environment requirements.

(c/image is, unlike Podman, simple and environment-independent enough that adding compatibility upstream seemed easier than maintaining old stable branches; the major issue was just noticing that we broke something, hence this PR.

OTOH that was much more of an issue when still targeting RHEL 7, and that’s no longer much of a concern.)

---

IMHO this PR should indeed be closed, it's no-longer relevant nor applicable given the amount of changes on the CI side.

Given the recent changes, and that this originally targeted RHEL 7, I agree; especially with the recent changes to build test base images separately, imposing RHEL 7 targets on that work doesn’t make sense any more.