DO NOT MERGE: Go142 test #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
go142-test
branch
2 times, most recently
from
1f8e1de
to
d30b23c
Compare
mtrmac
force-pushed
the
go142-test
branch
6 times, most recently
from
ca25d07
to
ec2a6aa
Compare
mtrmac
force-pushed
the
go142-test
branch
5 times, most recently
from
8cf6b03
to
266d0fc
Compare
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Jul 1, 2016
This fixes --version integration test on CentOS, as noticed by containers#91 . The underlying cause is: - Makefile builds with -ldflags "-X var=value", while go 1.4.2 only supports "-X var value". This causes centOS builds to be built without the specific commit information - The --version integration test assumes that commit information will always follow the version number. Changing either one of these would fix the build, changing the integration test has the advantage that we don't have to use the obsolete -X syntax and suffer warnings on newer Go versions.
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Jul 1, 2016
This fixes --version integration test on CentOS, as noticed by containers#91 . The underlying cause is: - Makefile builds with -ldflags "-X var=value", while go 1.4.2 only supports "-X var value". This causes CentOS builds to be built without the specific commit information - The --version integration test assumes that commit information will always follow the version number. Changing either one of these would fix the build, changing the integration test has the advantage that we don't have to use the obsolete -X syntax and suffer warnings on newer Go versions.
mtrmac
force-pushed
the
go142-test
branch
2 times, most recently
from
68c9ab4
to
710bbd7
Compare
mtrmac
force-pushed
the
go142-test
branch
2 times, most recently
from
6b9820f
to
4c26a4d
Compare
mtrmac
force-pushed
the
go142-test
branch
3 times, most recently
from
9f48bc6
to
c44991a
Compare
This is intended for use in Travis (or perhaps also locally). The default behavior remains the same, uses the fedora image. Adds various workarounds for Go 1.4; we should drop them ASAP. (Note that the (yum install) does not fail when one of the packages is missing. This is not a dealbreaker, but it will make diagnosing future bugs more difficult.)
This is currently known to fail due to containers#89
|
As of https://rhn.redhat.com/errata/RHSA-2016-1538.html / https://lists.centos.org/pipermail/centos-announce/2016-August/022005.html , CentOS has golang 1.6.3. so this is no longer relevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only to test #46 with #89 fixed.