idtools: fix ToHost conversion #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop a special case for RootPair that prevented the conversion of the UID/GID when it was matching the root user in the container. Closes: containers#1056 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
idtools-fix-mapping-to-host
branch
from
ece4884
to
c80f62c
Compare
flouthoc
approved these changes
Nov 9, 2021
|
LGTM |
nalind
added a commit
to nalind/storage
that referenced
this pull request
Mar 30, 2022
…sn't The godoc for pkg/idtools.ToHost() mentions that it makes an exception when either of the IDs to be mapped is 0, but that exception was removed in containers#1057. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
added a commit
to nalind/storage
that referenced
this pull request
Mar 30, 2022
…sn't The godoc for pkg/idtools.ToHost() mentions that it makes an exception when either of the IDs to be mapped is 0, but that special case was removed in containers#1057. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop a special case for RootPair that prevented the conversion of the
UID/GID when it was matching the root user in the container.
Closes: #1056
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com