Skip to content

idtools: don't say ToHost() makes exceptions in its godoc when it doesn't#1185

Merged
flouthoc merged 1 commit intocontainers:mainfrom
nalind:lies-in-comments
Mar 31, 2022
Merged

idtools: don't say ToHost() makes exceptions in its godoc when it doesn't#1185
flouthoc merged 1 commit intocontainers:mainfrom
nalind:lies-in-comments

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented Mar 30, 2022

The godoc for pkg/idtools.ToHost() mentions that it makes an exception when either of the IDs to be mapped is 0, but that special case was removed in #1057.

…sn't

The godoc for pkg/idtools.ToHost() mentions that it makes an exception
when either of the IDs to be mapped is 0, but that special case was
removed in containers#1057.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Copy link
Copy Markdown
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit bb2843d into containers:main Mar 31, 2022
@nalind nalind deleted the lies-in-comments branch March 31, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants