archive: ignore the security.selinux xattr #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
ignore the security.selinux xattr if it is present in the tarball header, since invalid labels cannot be set by unprivileged users and the `lsetxattr` syscall fails with EINVAL. Closes: containers#1076 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
ignore-security-selinux
branch
from
64241dd
to
9408ac3
Compare
|
@flouthoc PTAL |
flouthoc
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
LGTM.
I remember facing same issue with redroid image while debugging some issue. I left comment of selinux label here: containers/podman#12189 (comment) . I wonder what is the intention behind such image.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore the security.selinux xattr if it is present in the tarball header, since invalid labels cannot be set by unprivileged users and the
lsetxattrsyscall fails with EINVAL.Closes: #1076
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com