Fix lockfiles never detecting changes #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we ever check the last-writer of a lock file and get back a zero value, don't only check if subsequent last-writer values match its first zero bytes, which is always true, as a test to see if the last-writer value has remained unchanged. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
LGTM |
nalind
added a commit
to nalind/storage
that referenced
this pull request
Oct 18, 2022
Test changes introduced in containers#1396. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
added a commit
to nalind/storage
that referenced
this pull request
Oct 18, 2022
Test changes introduced in containers#1396. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we ever check the last-writer of a lock file and get back a zero value, don't only check if subsequent last-writer values match its first zero bytes, which is always true, as a test to see if the last-writer value has remained unchanged.
Related: containers/podman#16211