Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestLockfileMultiprocessModified() #1397

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Add TestLockfileMultiprocessModified() #1397

merged 2 commits into from
Oct 19, 2022

Conversation

nalind
Copy link
Member

@nalind nalind commented Oct 18, 2022

Test changes introduced in #1396. Should fail if either #1396 or #1391 is reverted.

@nalind
Add TestLockfileMultiprocessModified()
4293c48 
Test changes introduced in containers#1396.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind
Copy link
Member Author

nalind commented Oct 18, 2022

Tweaked to also verify calling Modified() again after calling it the first time, but before the last-writer is changed by anyone.

@rhatdan
Copy link
Member

rhatdan commented Oct 18, 2022

LGTM

mtrmac
mtrmac reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Overall approach LGTM.

pkg/lockfile/lockfile_test.go Outdated Show resolved Hide resolved
@rhatdan @mtrmac
Update pkg/lockfile/lockfile_test.go
c68c699 
Co-authored-by: Miloslav Trmač <mitr@redhat.com>
@rhatdan rhatdan merged commit 742493c into containers:main Oct 19, 2022
@nalind nalind mentioned this pull request Oct 19, 2022
Merged
@nalind nalind deleted the test-1391-1396 branch October 19, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nalind @rhatdan @mtrmac