Stop using golang.org/x/net/context #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Go >= 1.9, the implementation of the used parts of x/net/context just forwards to the standard library. So, use the standard library directly, and avoid the x/net dependency entirely. This should save a tiny bit of space in users like Podman. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
|
It’s like 30 kB of the object file, i.e much less in the whole binary… the big gains are elsewhere. I just noticed that we are actually linking this compatibility shim… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Go >= 1.9, the implementation of the used parts of x/net/context just forwards to the standard library.
So, use the standard library directly, and avoid the x/net dependency entirely. This should save a tiny bit of space in users like Podman.