Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/opencontainers/runc to v1.1.5 [security] #1543

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/opencontainers/runc require patch v1.1.4 -> v1.1.5

GitHub Vulnerability Alerts

CVE-2023-27561

runc 1.0.0-rc95 through 1.1.4 has Incorrect Access Control leading to Escalation of Privileges, related to libcontainer/rootfs_linux.go. To exploit this, an attacker must be able to spawn two containers with custom volume-mount configurations, and be able to run custom images. NOTE: this issue exists because of a CVE-2019-19921 regression.

CVE-2023-25809

Impact

It was found that rootless runc makes /sys/fs/cgroup writable in following conditons:

  1. when runc is executed inside the user namespace, and the config.json does not specify the cgroup namespace to be unshared (e.g.., (docker|podman|nerdctl) run --cgroupns=host, with Rootless Docker/Podman/nerdctl)
  2. or, when runc is executed outside the user namespace, and /sys is mounted with rbind, ro (e.g., runc spec --rootless; this condition is very rare)

A container may gain the write access to user-owned cgroup hierarchy /sys/fs/cgroup/user.slice/... on the host .
Other users's cgroup hierarchies are not affected.

Patches

v1.1.5 (planned)

Workarounds

  • Condition 1: Unshare the cgroup namespace ((docker|podman|nerdctl) run --cgroupns=private). This is the default behavior of Docker/Podman/nerdctl on cgroup v2 hosts.
  • Condition 2 (very rare): add /sys/fs/cgroup to maskedPaths

CVE-2023-28642

Impact

It was found that AppArmor, and potentially SELinux, can be bypassed when /proc inside the container is symlinked with a specific mount configuration.

Patches

Fixed in runc v1.1.5, by prohibiting symlinked /proc: https://github.com/opencontainers/runc/pull/3785

This PR fixes CVE-2023-27561 as well.

Workarounds

Avoid using an untrusted container image.


Release Notes

opencontainers/runc

v1.1.5: runc 1.1.5 -- "囚われた屈辱は 反撃の嚆矢だ"

Compare Source

This is the fifth patch release in the 1.1.z series of runc, which fixes
three CVEs found in runc.

In addition, the following other fixes are included in this release:

  • Fix the inability to use /dev/null when inside a container. (#​3620)
  • Fix changing the ownership of host's /dev/null caused by fd redirection
    (a regression in 1.1.1). (#​3674, #​3731)
  • Fix rare runc exec/enter unshare error on older kernels, including
    CentOS < 7.7. (#​3776)
  • nsexec: Check for errors in write_log(). (#​3721)
Static Linking Notices

The runc binary distributed with this release are statically linked with
the following GNU LGPL-2.1 licensed libraries, with runc acting
as a "work that uses the Library":

The versions of these libraries were not modified from their upstream versions,
but in order to comply with the LGPL-2.1 (§6(a)), we have attached the
complete source code for those libraries which (when combined with the attached
runc source code) may be used to exercise your rights under the LGPL-2.1.

However we strongly suggest that you make use of your distribution's packages
or download them from the authoritative upstream sources, especially since
these libraries are related to the security of your containers.


Thanks to all of the contributors who made this release possible:

[Due to the security-critical nature of this release, it was released
without a direct vote but was agreed to by the required number of
maintainers.]

Signed-off-by: Aleksa Sarai cyphar@cyphar.com


Configuration

📅 Schedule: Branch creation - "" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file security labels Mar 29, 2023
@rhatdan rhatdan force-pushed the renovate/go-github.com/opencontainers/runc-vulnerability branch from 6035528 to e94b0a6 Compare March 30, 2023 10:13
@renovate renovate bot force-pushed the renovate/go-github.com/opencontainers/runc-vulnerability branch 2 times, most recently from 3639ef4 to 899d202 Compare April 1, 2023 10:53
…curity]

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan force-pushed the renovate/go-github.com/opencontainers/runc-vulnerability branch from 899d202 to fc4f700 Compare April 1, 2023 15:46
@rhatdan
Copy link
Member

rhatdan commented Apr 1, 2023

LGTM

@rhatdan rhatdan merged commit 27c5c9a into main Apr 1, 2023
@renovate renovate bot deleted the renovate/go-github.com/opencontainers/runc-vulnerability branch April 1, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant