.cirrus.yml: fix a warning #1616
Conversation
|
@cevich PTAL |
|
Oof, this is confusing: None of the other testing tasks have this condition on them. WDYT about just removing it entirely? |
I barely remember this was made so some (expensive) tests can be skipped if only documentation changes are being made. Found this in a neighbor repo: I guess, yes, if this test skipping feature is not needed here, we can remove it entirely. |
|
Yeah, this and several other magic strings are used extensively in the podman and a few other repos. But in this repo, I count a total of 7 (closed) PRs using it, out of thousands. So I think it's safe to just remove it. That way no maintainer will ever question it's apparently partial implementation. Thanks for the effort though, trying to clean up all those annoying annotations. I appreciate the help. |
Cirrus CI emits a bunch of warnings like this one: > task "success" depends on task "fedora-38 vfs", but their only_if conditions are different This was probably copied from another repo, which uses CI:DOCS magic to skip some tests. In this repo, it is not used, so remove the condition. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
fix-cirrus-warn
branch
from
5f2cea3
to
cfa8c28
Compare
updated; ptal |
|
CI failures seem to be unrelated |
|
I just hit "re-run" on all the failures. |
Cirrus CI emits a bunch of warnings like this one:
To fix, use "skip" instead of "only_if". The difference between the two is described athttps://cirrus-ci.org/guide/writing-tasks/#conditional-task-execution
This was probably a copy-paste leftover from another repo, which uses CI:DOCS
magic to skip some tests. In this repo, it is not used, so remove the condition.