Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency containers/automation_images to v20231004 #1731

Merged
merged 3 commits into from Oct 25, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
containers/automation_images major 20230816t191118z-f38f37d13 -> 20231004t194547z-f39f38d13

Release Notes

containers/automation_images (containers/automation_images)

v20231004t194547z-f39f38d13

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 17, 2023
@renovate renovate bot requested a review from cevich October 17, 2023 17:25
@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from 43f51ee to 69f11e1 Compare October 18, 2023 13:42
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from 69f11e1 to 54b84d5 Compare October 19, 2023 07:46
@rhatdan
Copy link
Member

rhatdan commented Oct 19, 2023

@cevich PTAL

Signed-off-by: Chris Evich <cevich@redhat.com>
ZFS isn't supported in debian, it's always been a community side-load
situation (think EPEL for CentOS).  This is the only containers repo.
that makes use of it in CI.  Worse, since we're testing with SID,
installing (i.e. compiling) the ZFS kernel module is an even more
fragile and failure prone process.  Because of those issues I've
stripped it out of these CI VM images.  I no-longer wish to support
its use in this CI setup.  If somebody else wants to support it, they're
more than welcome and free to do so.

Signed-off-by: Chris Evich <cevich@redhat.com>
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the problem 😁 (maybe - see note below)

@@ -113,8 +113,6 @@ debian_testing_task: &debian_testing
TEST_DRIVER: "fuse-overlay-whiteout"
- env:
TEST_DRIVER: "btrfs"
- env:
TEST_DRIVER: "zfs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ref. related commit message in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZFS isn't supported in debian, it's always been a community side-load
situation (think EPEL for CentOS). This is the only containers repo.
that makes use of it in CI. Worse, since we're testing with SID,
installing (i.e. compiling) the ZFS kernel module is an even more
fragile and failure prone process. Because of those issues I've
stripped it out of these CI VM images. I no-longer wish to support
its use in this CI setup. If somebody else wants to support it, they're
more than welcome and free to do so.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@renovate
Copy link
Contributor Author

renovate bot commented Oct 20, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rhatdan
Copy link
Member

rhatdan commented Oct 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2023
@openshift-ci openshift-ci bot merged commit aefa111 into main Oct 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants