Skip to content

Commit

Permalink
images: Add label for tagging, not tied to the fedora-toolbox name
Browse files Browse the repository at this point in the history
Currently the toolbox script identifies toolbox images and containers
by checking whether the com.redhat.component label matches
"fedora-toolbox". However, as per the Fedora Container Guidelines [1],
the com.redhat.com label should match the Red Hat Bugzilla component
name where bugs against the image should be reported. This means that
images derived from the base fedora-toolbox image would likely end up
overwriting it.

One option would've been to mandate that all toolbox images have the
"fedora-toolbox-" prefix in their names. However, it's better to avoid
putting limitations on how images can be named. The "fedora" name
wouldn't anyway work for images based on other distributions, and not
all images are going to use the Red Hat bugzilla for tracking bugs.

It's better to use a tag that's uniquely associated with the toolbox
project, and isn't tied to a particular distribution or bug tracker.

[1] https://fedoraproject.org/wiki/Container:Guidelines
  • Loading branch information
debarshiray committed Mar 25, 2019
1 parent 668f7dc commit 0ab6eb7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion images/fedora/f28/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
FROM registry.fedoraproject.org/fedora:28

ENV NAME=fedora-toolbox VERSION=28
LABEL com.redhat.component="$NAME" \
LABEL com.github.debarshiray.toolbox="true" \
com.redhat.component="$NAME" \
name="$FGC/$NAME" \
version="$VERSION" \
usage="This image is meant to be used with the toolbox command" \
Expand Down
3 changes: 2 additions & 1 deletion images/fedora/f29/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
FROM registry.fedoraproject.org/fedora:29

ENV NAME=fedora-toolbox VERSION=29
LABEL com.redhat.component="$NAME" \
LABEL com.github.debarshiray.toolbox="true" \
com.redhat.component="$NAME" \
name="$FGC/$NAME" \
version="$VERSION" \
usage="This image is meant to be used with the toolbox command" \
Expand Down
3 changes: 2 additions & 1 deletion images/fedora/f30/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
FROM registry.fedoraproject.org/fedora:30

ENV NAME=fedora-toolbox VERSION=30
LABEL com.redhat.component="$NAME" \
LABEL com.github.debarshiray.toolbox="true" \
com.redhat.component="$NAME" \
name="$FGC/$NAME" \
version="$VERSION" \
usage="This image is meant to be used with the toolbox command" \
Expand Down
3 changes: 2 additions & 1 deletion images/fedora/f31/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
FROM registry.fedoraproject.org/fedora:31

ENV NAME=fedora-toolbox VERSION=31
LABEL com.redhat.component="$NAME" \
LABEL com.github.debarshiray.toolbox="true" \
com.redhat.component="$NAME" \
name="$FGC/$NAME" \
version="$VERSION" \
usage="This image is meant to be used with the toolbox command" \
Expand Down

0 comments on commit 0ab6eb7

Please sign in to comment.