playbooks: Require GCC and show its version #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building Toolbx requires a C compiler [1], which defaults to GCC on Fedora and CentOS Stream. It's good to explicitly require it, so that it doesn't go missing from the build. Showing the version of the C compiler is a big help when debugging weird build problems involving the toolchain. A following commit will use CGO to link to libsubid.so, which will only increase the relevance of the C compiler. [1] Commit c8aaed5 containers#923 containers#1218
debarshiray
force-pushed
the
wip/rishi/playbooks-gcc
branch
from
017c311
to
e3b4b5e
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 32s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building Toolbx requires a C compiler [1], which defaults to GCC on Fedora and CentOS Stream. It's good to explicitly require it, so that it doesn't go missing from the build.
Showing the version of the C compiler is a big help when debugging weird build problems involving the toolchain. A following commit will use CGO to link to libsubid.so, which will only increase the relevance of the C compiler.
[1] Commit c8aaed5
#923