build: Don't assume that libc.so is always in /usr/lib or /usr/lib64 #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The location for public shared libraries can change from one operating system distribution to another. eg., while Fedora uses /usr/lib and /usr/lib64, depending on the hardware architecture, Debian uses paths like /usr/lib/x86_64-linux-gnu. Therefore, it's best not to assume anything and ask the toolchain. containers#923
debarshiray
force-pushed
the
wip/rishi/rpath-query-toolchain
branch
from
1ee6e27
to
c8aaed5
Compare
|
Build succeeded.
|
debarshiray
commented
Nov 13, 2021
| @@ -27,7 +27,22 @@ if ! cd "$1"; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| go build -trimpath -ldflags "-extldflags '-Wl,-rpath,/run/host/usr/lib -Wl,-rpath,/run/host/usr/lib64' -linkmode external -X github.com/containers/toolbox/pkg/version.currentVersion=$3" -o "$2/toolbox" | |||
| if ! libc_dir=$("$4" --print-file-name=libc.so); then | |||
There was a problem hiding this comment.
I wish there was a way to do this with Meson's compiler.find_library.
HarryMichal
added
2. Build System
|
Thanks for this! Testing on Debian would be helpful in this case. One solution is to add support to SoftwareFactory or just use GitHub Actions since we mainly want to test the build and that can be done in a container, too. Further testing would require support in SoftwareFactory since we require a VM for testing purpose and not a container. |
debarshiray
added a commit
to containers/containertoolbx.org
that referenced
this pull request
Dec 9, 2021
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 27, 2023
Building Toolbx requires a C compiler [1], which defaults to GCC on Fedora and CentOS Stream. It's good to explicitly require it, so that it doesn't go missing from the build. Showing the version of the C compiler is a big help when debugging weird build problems involving the toolchain. A following commit will use CGO to link to libsubid.so, which will only increase the relevance of the C compiler. [1] Commit c8aaed5 containers#923
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 27, 2023
Building Toolbx requires a C compiler [1], which defaults to GCC on Fedora and CentOS Stream. It's good to explicitly require it, so that it doesn't go missing from the build. Showing the version of the C compiler is a big help when debugging weird build problems involving the toolchain. A following commit will use CGO to link to libsubid.so, which will only increase the relevance of the C compiler. [1] Commit c8aaed5 containers#923 containers#1218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location for public shared libraries can change from one operating
system distribution to another. eg., while Fedora uses /usr/lib and
/usr/lib64, depending on the hardware architecture, Debian uses paths
like /usr/lib/x86_64-linux-gnu. Therefore, it's best not to assume
anything and ask the toolchain.