images/fedora: Tweaks and tests #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Oct 4, 2023
debarshiray
force-pushed
the
wip/rishi/images-fedora-reorder-whois
branch
from
7b29e5d
to
50126cd
Compare
|
Build failed. ✔️ unit-test SUCCESS in 13m 10s |
Until now, only the packages that are present in the fedora base image, and had their documentation stripped out, were being tested for the availability of documentation. There were no tests for the extra packages that get added to the base image to form the fedora-toolbox image. The util-linux and xz packages were picked as examples for these new tests. The xz package is a particularly good example because it has translations for its manuals. It can help test that the fedora-toolbox image is localized just like Fedora Silverblue and Workstation. Only the images for currently maintained Fedoras (ie., 37, 38 and 39) were updated. containers#1384
debarshiray
force-pushed
the
wip/rishi/images-fedora-reorder-whois
branch
from
50126cd
to
20188a0
Compare
debarshiray
changed the title
|
Build failed. ✔️ unit-test SUCCESS in 8m 13s |
|
There are still some test failures on Fedora Rawhide and Fedora 39. For example, these that seem to be because of changes in various other components in Fedora: However, at least these two failures are a fallout from the Fedora 39 Change that made the The images are now built with Image Factory with Kickstarts and Pungi instead of with OpenShift Build Service cluster from Dockerfiles. During that migration we lost the I submitted some pull requests to address that: In the mean time, while we track down and fix these failures, I am going to temporarily override these failures. |
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Oct 19, 2023
It's currently being pulled in as a dependency of iproute. However,
since it's explicitly mentioned in the list of default packages on
Fedora Silverblue and Workstation [1], it should be mentioned here too.
The psmisc package marks the translations for its manuals with %lang().
Therefore, it's a very good example for testing that the fedora-toolbox
image is localized just like Fedora Silverblue and Workstation.
This is unlike the xz package, whose translations for manuals were added
to the tests recently [2]. The xz package doesn't mark its translated
manuals with %lang() [3], which means that they are going to get
installed regardless of whether RPM has been configured to not install
localization files or not. eg., through the %_install_langs macro. So,
they aren't a good candidate for the tests until this is fixed.
[1] fedora-comps commit e4ed54dfcc497fd0
https://pagure.io/fedora-comps/c/e4ed54dfcc497fd0
https://pagure.io/fedora-comps/pull-request/379
[2] Commit 20188a0
containers@20188a097a1a7a16
containers#1384
[3] https://src.fedoraproject.org/rpms/xz/pull-request/10
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Oct 19, 2023
It's currently being pulled in as a dependency of iproute. However,
since it's explicitly mentioned in the list of default packages on
Fedora Silverblue and Workstation [1], it should be mentioned here too.
The psmisc package marks the translations for its manuals with %lang().
Therefore, it's a very good example for testing that the fedora-toolbox
image is localized just like Fedora Silverblue and Workstation.
This is unlike the xz package, whose translations for manuals were added
to the tests recently [2]. The xz package doesn't mark its translated
manuals with %lang() [3], which means that they are going to get
installed regardless of whether RPM has been configured to not install
localization files or not. eg., through the %_install_langs macro. So,
they aren't a good candidate for the tests until this is fixed.
[1] fedora-comps commit e4ed54dfcc497fd0
https://pagure.io/fedora-comps/c/e4ed54dfcc497fd0
https://pagure.io/fedora-comps/pull-request/379
[2] Commit 20188a0
containers@20188a097a1a7a16
containers#1384
[3] https://src.fedoraproject.org/rpms/xz/pull-request/10
containers#1390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.