Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Make Fedora 37, 38 and 39 more fool proof by adding psmisc and some more files to the tests #1390

Conversation

debarshiray
Copy link
Member

No description provided.

It's currently being pulled in as a dependency of iproute.  However,
since it's explicitly mentioned in the list of default packages on
Fedora Silverblue and Workstation [1], it should be mentioned here too.

The psmisc package marks the translations for its manuals with %lang().
Therefore, it's a very good example for testing that the fedora-toolbox
image is localized just like Fedora Silverblue and Workstation.

This is unlike the xz package, whose translations for manuals were added
to the tests recently [2].  The xz package doesn't mark its translated
manuals with %lang() [3], which means that they are going to get
installed regardless of whether RPM has been configured to not install
localization files or not.  eg., through the %_install_langs macro.  So,
they aren't a good candidate for the tests until this is fixed.

[1] fedora-comps commit e4ed54dfcc497fd0
    https://pagure.io/fedora-comps/c/e4ed54dfcc497fd0
    https://pagure.io/fedora-comps/pull-request/379

[2] Commit 20188a0
    containers@20188a097a1a7a16
    containers#1384

[3] https://src.fedoraproject.org/rpms/xz/pull-request/10

containers#1390
@debarshiray debarshiray force-pushed the wip/rishi/images-fedora-test-psmisc-man-db-tests branch from 1eafe68 to e41d920 Compare October 19, 2023 16:31
@softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/bd85e6fde3584d07b0e363d1a48f3164

✔️ unit-test SUCCESS in 8m 36s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 17s
✔️ unit-test-restricted SUCCESS in 7m 42s
system-test-fedora-rawhide FAILURE in 36m 33s
system-test-fedora-39 FAILURE in 35m 03s
✔️ system-test-fedora-38 SUCCESS in 28m 30s
✔️ system-test-fedora-37 SUCCESS in 28m 51s

@debarshiray debarshiray merged commit e41d920 into containers:main Oct 23, 2023
2 of 3 checks passed
@debarshiray debarshiray deleted the wip/rishi/images-fedora-test-psmisc-man-db-tests branch October 23, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant