Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/fedora: Add translations for gawk, and all the iconv converter modules for glibc #1456

Conversation

debarshiray
Copy link
Member

Only the images for currently maintained Fedoras (ie., 38 and 39) were updated.

Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a5787c5da38d4186a1b8154e26c59da3

✔️ unit-test SUCCESS in 4m 48s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 27s
✔️ unit-test-restricted SUCCESS in 3m 46s
✔️ system-test-fedora-rawhide SUCCESS in 32m 42s
✔️ system-test-fedora-39 SUCCESS in 34m 17s
✔️ system-test-fedora-38 SUCCESS in 33m 30s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Feb 22, 2024
Only the images for currently maintained Fedoras (ie., 38 and 39) were
updated.

containers#1456
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Feb 22, 2024
The concept of a 'base' image for creating Toolbx containers hasn't
existed since Toolbx 0.0.10, when the Buildah dependency and the
user-specific customized image were dropped [1].  That was a long time
ago.  Toolbx containers created before that were never supported by the
Go implementation [2].

Therefore, it's time to update the terminology.

Only the images for currently maintained Fedoras (ie., 38 and 39) were
updated.

[1] Commit 8b84b5e
    containers@8b84b5e4604921fa
    containers#160

[2] Commit 238f245
    containers@238f2451e7d7d54a
    containers#318

containers#1456
@debarshiray debarshiray force-pushed the wip/rishi/images-fedora-gawk-all-langpacks branch from e2c9f76 to fc2ad6e Compare February 22, 2024 00:11
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/cf6843108a064d9f8796801d6ffc2205

✔️ unit-test SUCCESS in 5m 22s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 6m 13s
✔️ unit-test-restricted SUCCESS in 3m 58s
✔️ system-test-fedora-rawhide SUCCESS in 47m 22s
✔️ system-test-fedora-39 SUCCESS in 47m 54s
✔️ system-test-fedora-38 SUCCESS in 48m 51s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Feb 22, 2024
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Feb 22, 2024
The concept of a 'base' image for creating Toolbx containers hasn't
existed since Toolbx 0.0.10, when the Buildah dependency and the
user-specific customized image were dropped [1].  That was a long time
ago.  Toolbx containers created before that were never supported by the
Go implementation [2].

Therefore, it's time to update the terminology.

[1] Commit 8b84b5e
    containers@8b84b5e4604921fa
    containers#160

[2] Commit 238f245
    containers@238f2451e7d7d54a
    containers#318

containers#1456
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Feb 22, 2024
@debarshiray debarshiray force-pushed the wip/rishi/images-fedora-gawk-all-langpacks branch from fc2ad6e to 608ad7b Compare February 22, 2024 01:19
@debarshiray debarshiray changed the title images/fedora: Add translations for gawk images/fedora: Add translations for gawk, and all the iconv converter modules for glibc Feb 22, 2024
Currently, the gawk package mentions gawk-all-langpacks, which contains
the translations, as a weak dependency [1].  However, the gawk package
is part of the fedora base image, which doesn't include weak
dependencies [2], and that leads to gawk-all-langpacks going missing.

[1] Fedora gawk commit ef1d4dbefb5ccbe6
    https://src.fedoraproject.org/rpms/gawk/c/ef1d4dbefb5ccbe6

[2] fedora-kickstarts commit 1c39c0adb0d44866
    https://pagure.io/fedora-kickstarts/c/1c39c0adb0d44866
    https://pagure.io/fedora-kickstarts/pull-request/551
    https://pagure.io/releng/issue/8530

containers#1456
The concept of a 'base' image for creating Toolbx containers hasn't
existed since Toolbx 0.0.10, when the Buildah dependency and the
user-specific customized image were dropped [1].  That was a long time
ago.  Toolbx containers created before that were never supported by the
Go implementation [2].

Therefore, it's time to update the terminology.

[1] Commit 8b84b5e
    containers@8b84b5e4604921fa
    containers#160

[2] Commit 238f245
    containers@238f2451e7d7d54a
    containers#318

containers#1456
Currently, the glibc package mentions glibc-gconv-extra, which contains
the iconv converter modules that are not commonly used, as a weak
dependency [1].  However, the glibc package is part of the fedora base
image, which doesn't include weak dependencies [2], and that leads to
glibc-gconv-extra going missing.

Only the images for currently maintained Fedoras (ie., 38 and 39) were
updated.

[1] Fedora glibc commit 51ca5d3334c3cd35
    https://src.fedoraproject.org/rpms/glibc/c/51ca5d3334c3cd35
    https://src.fedoraproject.org/rpms/glibc/pull-request/36
    https://bugzilla.redhat.com/show_bug.cgi?id=1812191

[2] fedora-kickstarts commit 1c39c0adb0d44866
    https://pagure.io/fedora-kickstarts/c/1c39c0adb0d44866
    https://pagure.io/fedora-kickstarts/pull-request/551
    https://pagure.io/releng/issue/8530

containers#1456
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2dda27adec9f4257a016af69c595c719

✔️ unit-test SUCCESS in 5m 10s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 04s
✔️ unit-test-restricted SUCCESS in 4m 14s
✔️ system-test-fedora-rawhide SUCCESS in 32m 48s
✔️ system-test-fedora-39 SUCCESS in 35m 53s
✔️ system-test-fedora-38 SUCCESS in 35m 09s

@debarshiray debarshiray force-pushed the wip/rishi/images-fedora-gawk-all-langpacks branch from 608ad7b to 3ca7e86 Compare February 22, 2024 02:00
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c3be08ab643244a5b01dd877beafafb0

✔️ unit-test SUCCESS in 5m 19s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 40s
✔️ unit-test-restricted SUCCESS in 4m 00s
✔️ system-test-fedora-rawhide SUCCESS in 32m 53s
✔️ system-test-fedora-39 SUCCESS in 33m 44s
✔️ system-test-fedora-38 SUCCESS in 34m 24s

@debarshiray debarshiray merged commit 3ca7e86 into containers:main Feb 22, 2024
3 checks passed
@debarshiray debarshiray deleted the wip/rishi/images-fedora-gawk-all-langpacks branch February 22, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant