Refactor to proper abstract class #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
approved these changes
Oct 19, 2020
JAORMX
requested changes
Oct 19, 2020
It's fixed in PR #76 ; once that PR is merged I'll rebase. Also because this PR uses |
EngineHelper is an abstract class and should be treated like abstract class using python stdlib tools Note: `ABC` class available from py3.4 Signed-off-by: Martin Bašti <mbasti@redhat.com>
MartinBasti
force-pushed
the
proper-abstract-class
branch
from
8b663f2
to
0905fef
Compare
|
Rebased |
JAORMX
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EngineHelper is an abstract class and should be treated like abstract class using python stdlib tools
Signed-off-by: Martin Bašti mbasti@redhat.com