Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the validation logic into executor #2258

Merged
merged 4 commits into from
Aug 22, 2023
Merged

move the validation logic into executor #2258

merged 4 commits into from
Aug 22, 2023

Commits on Aug 20, 2023

  1. move the validation logic into executor 

    To allow more flexibility for the executor, we move the validate logic into the executor.
The validate runs in the `create` step before workloads are executed.
Instead of implementing the validation in the `exec`, to maintain
backward competiability, we have to introduce an extra step. The exec is
too late to fail if the spec is not validated.

Signed-off-by: yihuaf <yihuaf@unkies.org>
    @yihuaf
    yihuaf committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    ec0efd3 View commit details
    Browse the repository at this point in the history

  2. Update the migration guide 

    Signed-off-by: yihuaf <yihuaf@unkies.org>
    @yihuaf
    yihuaf committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    4867118 View commit details
    Browse the repository at this point in the history

  3. Add a comment explaining when the validate step runs. 

    Signed-off-by: yihuaf <yihuaf@unkies.org>
    @yihuaf
    yihuaf committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    ad5ef2c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Implement different error types for validate 

    Signed-off-by: yihuaf <yihuaf@unkies.org>
    @yihuaf
    yihuaf committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    940750e View commit details
    Browse the repository at this point in the history