Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chroot when not entering into mount namespace #242

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Aug 28, 2021

Do not pivot_root when under the host mount namespace. Chroot instead.

Fix #240

Also passes "linux_ns_itype/linux_ns_itype.t" test.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@utam0k
Copy link
Member

utam0k commented Aug 28, 2021

@yihuaf This test has been running forever. Can you check it out?

Running linux_ns_itype/linux_ns_itype.t

@yihuaf
Copy link
Collaborator Author

yihuaf commented Aug 28, 2021

@yihuaf This test has been running forever. Can you check it out?

Running linux_ns_itype/linux_ns_itype.t

Yes I will.

@yihuaf yihuaf changed the title Final fix to linux_ns_itype tests [WIP] Final fix to linux_ns_itype tests Aug 28, 2021
Do not pivot_root when under the host mount namespace. Chroot instead.
@yihuaf yihuaf force-pushed the yihuaf/240 branch 4 times, most recently from dfc43e2 to c068e7c Compare August 30, 2021 01:05
@yihuaf
Copy link
Collaborator Author

yihuaf commented Aug 30, 2021

@utam0k So the hang has been reported since 2019. (opencontainers/runtime-tools#698). I'd rather get this change in without this test. On my local machine, I can't reproduce this. The test passes with flying color. On the Github action, the test passes, but as the issue indicated hang on the clean stage. What do you think?

@utam0k
Copy link
Member

utam0k commented Aug 30, 2021

@utam0k So the hang has been reported since 2019. (opencontainers/runtime-tools#698). I'd rather get this change in without this test. On my local machine, I can't reproduce this. The test passes with flying color. On the Github action, the test passes, but as the issue indicated hang on the clean stage. What do you think?

Oops... Thanks for your research. Let's comment on what goes through locally and the problems and comment it out.
Lastly, just to confirm, if it doesn't work under certain conditions, we can consider skipping it with check_enviroment(), but is that going to be difficult? (I don't think you need to spend that much time investigating this.)

When you will do, it would be helpful if you could also update the README.md in a similar fashion to following PR.

@yihuaf yihuaf changed the title [WIP] Final fix to linux_ns_itype tests Use chroot when not entering into mount namespace Aug 30, 2021
@yihuaf yihuaf merged commit e3b5720 into containers:main Aug 30, 2021
@yihuaf yihuaf deleted the yihuaf/240 branch August 30, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the host mount namespace, we should not pivot_root
2 participants