-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chdir
in container init
and start
#2777
Conversation
Hey, the CI is failing because cross now requires rust 1.77.2 and we use 1.77.1. Have opened #2779 which should fix all the CI running issues, so once that is merged, you can rebase on that. |
It is merged, so you can go ahead 👍 |
the invoke to chdir is immediately called again in notify_socket.notify_container_start() and it seems not necessary. This commit removes it Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Hey @Mossaka , I've rebased your branch, I hope that's fine. |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
It seems like the integration test failed. I am not able to tell if it's related to my changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait until we investigat this as it could break pseudo terminal.
Sounds good. That's why I made this PR a draft one until we figure out if it's not breaking existing functionality of youki. |
3 tests failed, all related to setting up tty.
|
I was worried about catching it on the test, but it looks like they were testing it! I want to thank our past selves. |
Sorry, but I've created another PR to fix it. |
Remove unnecessary
chdir
in containerinit
andstart
, the invokes seem not necessary.Pending comments from #2772 (comment) and will close issue #2772