Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement seccomp notify #330

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Implement seccomp notify #330

merged 4 commits into from
Sep 28, 2021

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Sep 25, 2021

This is the first part of the change where we support seccomp notify (#307) and returning a fd for seccomp.

Next, we will implement the seccomp listeaner in the OCI spec.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #330 (88fa0af) into main (8250b48) will increase coverage by 0.01%.
The diff coverage is 68.85%.

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   70.37%   70.38%   +0.01%     
==========================================
  Files          46       46              
  Lines        6737     6790      +53     
==========================================
+ Hits         4741     4779      +38     
- Misses       1996     2011      +15     

src/seccomp/mod.rs Outdated Show resolved Hide resolved
src/seccomp/mod.rs Outdated Show resolved Hide resolved
@utam0k
Copy link
Member

utam0k commented Sep 25, 2021

Is it possible to break the mod.rs down into a few more files?

@yihuaf
Copy link
Collaborator Author

yihuaf commented Sep 26, 2021

Is it possible to break the mod.rs down into a few more files?

We can, but it is still a coherent block at the moment. The only relevant pub function here is initialize_seccomp. All the other bits are in the service of this function. Maybe next time when this file gets larger.

@utam0k
Copy link
Member

utam0k commented Sep 26, 2021

We can, but it is still a coherent block at the moment. The only relevant pub function here is initialize_seccomp. All the other bits are in the service of this function. Maybe next time when this file gets larger.

Ok, I agree with you.

@yihuaf yihuaf requested a review from utam0k September 27, 2021 23:08
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k merged commit 884428a into containers:main Sep 28, 2021
@yihuaf yihuaf deleted the yihuaf/307 branch September 28, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants