This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Replace Base64 encoding by Gzip compression #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
force-pushed
the
feature/compress_uint8_array-15
branch
from
45c339b
to
8ea7131
Compare
1 similar comment
vdemeester
reviewed
Feb 5, 2018
kv.go
Outdated
| @@ -155,11 +158,21 @@ func decodeHook(fromType reflect.Type, toType reflect.Type, data interface{}) (i | |||
|
|
|||
| return dataOutput, nil | |||
| } else if fromType.Kind() == reflect.String { | |||
| b, err := base64.StdEncoding.DecodeString(data.(string)) | |||
| buffer := bytes.NewBuffer([]byte(data.(string))) | |||
| reader, err := gzip.NewReader(buffer) | |||
There was a problem hiding this comment.
You could make that a bit more composable (might be overkill for the current codebase though — and I'm really bad at naming functions)
func base64Reader(r io.Reader) (*Reader, error) {
return base64.NewDecoder(base64.StdEncoding, r)
}
func readByPrecedence(r io.Reader, fs ...func(io.Reader) (*Reader, error)) ([]byte, error) {
var err error
for _, f := range fs {
reader, err := f(r)
if err == nil {
return ioutil.ReadAll(reader)
}
}
return nil, err
}
// […]
data := bytes.NewBuffer([]byte(data.(string)))
reaturn readByPrecedence(data, gzip.NewReader, base64Reader)
// […]
vdemeester
suggested changes
Feb 6, 2018
kv.go
Outdated
| } | ||
| } | ||
| return data, nil | ||
| } | ||
|
|
||
| func gzipReader(data interface{}) (interface{}, error) { |
There was a problem hiding this comment.
interface{} in arg and return seems a bit risky if you wanna reuse that func. I would do the cast before and return io.Reader, error 👼
vdemeester
suggested changes
Feb 6, 2018
kv.go
Outdated
| } | ||
|
|
||
| func base64Reader(data string) ([]byte, error) { | ||
| return base64.StdEncoding.DecodeString(data) | ||
| func gzipReader(r io.Reader) (io.Reader, error) { |
There was a problem hiding this comment.
You don't need that, just pass gzip.NewReader when calling readCompressedData 😉
vdemeester
approved these changes
Feb 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, byte array are Base64 encoded before to be stored in a KV store.
But the size of these data can be a problem.
Indeed, KV stores, like Consul, can only store values with a size up to 500 KB.
This PR allows replacing Base64 encoded data by gzip compressed data to reduce the size of these data.
Note : If data cannot be unzipped, they are Base64 decoded to preserve the backward compatibility.
Unit tests have been updated too.
Related to traefik/traefik#1325