Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic APM tracer implementation #5870

Merged
merged 11 commits into from Nov 27, 2019
Merged

Conversation

@amine7536
Copy link
Contributor

amine7536 commented Nov 19, 2019

What does this PR do?

Adding support for Elastic APM tracing system. https://www.elastic.co/products/apm

Motivation

It is an OpenTracing compatible tracer and we are planning to use it.

More

  • Added/updated tests
  • Added/updated documentation
@ldez ldez added this to To review in v2 via automation Nov 20, 2019
@ldez ldez requested a review from mmatur Nov 20, 2019
mmatur added 3 commits Nov 25, 2019
@mmatur

This comment has been minimized.

Copy link
Member

mmatur commented Nov 25, 2019

Thanks @amine7536 for you contribution

I tested your PR with an example available here, everything works well.

@mmatur mmatur added this to the next milestone Nov 25, 2019
@mmatur
mmatur approved these changes Nov 27, 2019
Copy link
Member

mmatur left a comment

Thanks for the contribution.
LGTM

@ldez
ldez approved these changes Nov 27, 2019
Copy link
Member

ldez left a comment

Thanks 👍

Copy link
Contributor

jbdoumenjou left a comment

LGTM

@traefiker traefiker merged commit fe8b090 into containous:master Nov 27, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details
v2 automation moved this from To review to Done Nov 27, 2019
@amine7536 amine7536 deleted the amine7536:feat-elastic-apm branch Nov 27, 2019
@amine7536

This comment has been minimized.

Copy link
Contributor Author

amine7536 commented Nov 27, 2019

Hi, thanks for the approval.
Keep up the good work, Traefik is awesome 💪.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.