Update package management with Glide #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
no-more-godep-ever
branch
from
645884b
to
743e446
Compare
|
|
|
|
||
| COPY . /go/src/github.com/emilevauge/traefik | ||
|
|
||
| ENV GOPATH /go |
There was a problem hiding this comment.
Not sure this is needed (should be set by the parent image golang)
There was a problem hiding this comment.
You're right, corrected
emilevauge
force-pushed
the
no-more-godep-ever
branch
4 times, most recently
from
df1599c
to
93b28eb
Compare
emilevauge
force-pushed
the
no-more-godep-ever
branch
from
93b28eb
to
784dc9e
Compare
|
|
|
By the way, looks good, seems good, works good so LGTM 🐹. |
vdemeester
added a commit
that referenced
this pull request
Oct 13, 2015
Update package management with Glide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more Godep!!!
Please welcome Glide :)
This resolves https://github.com/EmileVauge/traefik/issues/35