Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord format update, preparations for rich message support #108

Merged
merged 11 commits into from
Jan 31, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 9, 2021

Updates to Discord Service to use embeds instead of content, mimicking the format used by the Discord Slack webhook wrapper

"Global" rich message support split out into new branch for v0.5.0

@piksel piksel marked this pull request as draft January 9, 2021 17:50
@codecov-io
Copy link

codecov-io commented Jan 9, 2021

Codecov Report

Merging #108 (c8ea23d) into main (61e5b37) will increase coverage by 1.50%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   64.19%   65.70%   +1.50%     
==========================================
  Files          55       56       +1     
  Lines        1296     1347      +51     
==========================================
+ Hits          832      885      +53     
+ Misses        397      383      -14     
- Partials       67       79      +12     
Impacted Files Coverage Δ
pkg/services/discord/discord.go 54.54% <50.00%> (+32.80%) ⬆️
pkg/services/discord/discord_config.go 82.35% <75.00%> (+19.19%) ⬆️
pkg/services/discord/discord_json.go 90.47% <90.47%> (+46.03%) ⬆️
pkg/util/util_numbers.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e5b37...c8ea23d. Read the comment docs.

@simskij simskij changed the base branch from master to main January 9, 2021 20:53
# Conflicts:
#	pkg/format/formatter.go
#	pkg/types/message_item.go
#	pkg/util/util_test.go
Revert "feat: implement simple rich send wrapper for all services"

This reverts commit fe5d43f
@piksel piksel modified the milestones: v0.5.0, v0.4.0 Jan 31, 2021
@piksel piksel marked this pull request as ready for review January 31, 2021 17:09
@piksel piksel changed the title Rich message support / Discord update Discord format update, preparations for rich message support Jan 31, 2021
@piksel piksel merged commit 8d40146 into main Jan 31, 2021
@piksel piksel deleted the feat/dicord_embeds branch January 31, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants