-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord format update, preparations for rich message support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 64.19% 65.70% +1.50%
==========================================
Files 55 56 +1
Lines 1296 1347 +51
==========================================
+ Hits 832 885 +53
+ Misses 397 383 -14
- Partials 67 79 +12
Continue to review full report at Codecov.
|
- also prepares for rich message sending
this includes the web color format #xxxxxx
piksel
force-pushed
the
feat/dicord_embeds
branch
from
January 10, 2021 16:37
4e4b4ab
to
fe5d43f
Compare
piksel
force-pushed
the
feat/dicord_embeds
branch
from
January 10, 2021 19:00
dee7b57
to
2cd5785
Compare
# Conflicts: # pkg/format/formatter.go # pkg/types/message_item.go # pkg/util/util_test.go
piksel
force-pushed
the
feat/dicord_embeds
branch
from
January 31, 2021 16:55
7038c99
to
f6d91f5
Compare
Revert "feat: implement simple rich send wrapper for all services" This reverts commit fe5d43f
piksel
changed the title
Rich message support / Discord update
Discord format update, preparations for rich message support
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Discord Service to use embeds instead of content, mimicking the format used by the Discord Slack webhook wrapper
"Global" rich message support split out into new branch for v0.5.0