Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ground work for rich message support #121

Merged
merged 5 commits into from
Jan 31, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 17, 2021

This contains some cherry-picked commits from #108 that should make it possible to continue working on rich message support.

Using this, the services can begin implementing the support.

This will not pass Codacy and Codecov checks due to it mostly just add unused shared helpers and interfaces.

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #121 (d2a0913) into main (c7b9fb9) will increase coverage by 1.80%.
The diff coverage is 81.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   58.54%   60.34%   +1.80%     
==========================================
  Files          55       55              
  Lines        1165     1223      +58     
==========================================
+ Hits          682      738      +56     
  Misses        434      434              
- Partials       49       51       +2     
Impacted Files Coverage Δ
pkg/router/router.go 60.86% <0.00%> (+0.86%) ⬆️
pkg/util/partition_message.go 95.45% <95.45%> (ø)
pkg/util/util.go 100.00% <100.00%> (ø)
pkg/util/util_kinds.go 100.00% <100.00%> (ø)
pkg/services/xmpp/xmpp.go 27.27% <0.00%> (-8.73%) ⬇️
pkg/services/rocketchat/rocketchat.go 14.28% <0.00%> (-3.90%) ⬇️
pkg/services/smtp/smtp_encmethod.go 62.50% <0.00%> (ø)
pkg/services/standard/standard_failures.go 0.00% <0.00%> (ø)
pkg/services/smtp/smtp.go 82.01% <0.00%> (+0.58%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b9fb9...d2a0913. Read the comment docs.

@piksel piksel added this to the v0.4.0 milestone Jan 23, 2021
@piksel piksel merged commit 9ef6db2 into main Jan 31, 2021
@piksel piksel deleted the feature/rich-send branch January 31, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant