Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(teams): use better URL format and nicer output #117

Merged
merged 7 commits into from
Jan 31, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 13, 2021

  • Change the URL format (with support for reading the old format) to one that is easier to type by hand
  • Add title and color fields
  • Use sections for messages (align with common bot output)
  • Correctly parse and test webhook URLs
  • Add groundwork for rich API

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #117 (8e8fa37) into main (7e4a3bf) will increase coverage by 3.08%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   61.11%   64.19%   +3.08%     
==========================================
  Files          55       55              
  Lines        1237     1296      +59     
==========================================
+ Hits          756      832      +76     
+ Misses        429      397      -32     
- Partials       52       67      +15     
Impacted Files Coverage Δ
pkg/services/teams/teams_token.go 38.46% <33.33%> (+38.46%) ⬆️
pkg/services/teams/teams_config.go 55.93% <55.76%> (+55.93%) ⬆️
pkg/services/teams/teams.go 76.92% <78.04%> (+55.04%) ⬆️
pkg/router/router.go 66.30% <0.00%> (+5.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a3bf...8e8fa37. Read the comment docs.

@piksel piksel merged commit 61e5b37 into main Jan 31, 2021
@piksel piksel deleted the fix/teams-tlc branch January 31, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant