Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add support for custom service URLs #125

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 23, 2021

This will allow services to opt in to supporting the service+custom URL schema, which can be used for simplifying the setup in basic scenarios, or to support multiple URL formats.

Example usage by teams in #117 :
User get a webhook URL from Teams, and simply prepends teams+ to the URL to make it a shoutrrr URL:
teams+https://outlook.office.com/webhook/12345....

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #125 (f058fb6) into main (6e64c70) will increase coverage by 1.81%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   58.15%   59.96%   +1.81%     
==========================================
  Files          55       55              
  Lines        1171     1184      +13     
==========================================
+ Hits          681      710      +29     
+ Misses        440      424      -16     
  Partials       50       50              
Impacted Files Coverage Δ
pkg/router/router.go 67.46% <50.00%> (+7.46%) ⬆️
pkg/router/servicemap.go 100.00% <0.00%> (+93.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e64c70...f058fb6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant