-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove broken badge and fix docker-compose snippet #1025
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1025 +/- ##
=======================================
Coverage 59.63% 59.63%
=======================================
Files 22 22
Lines 1412 1412
=======================================
Hits 842 842
Misses 500 500
Partials 70 70 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I actually thought we already had removed it...
@all-contributors add @djquan for doc |
I've put up a pull request to add @djquan! 🎉 |
Hi, on the webpage, the docker-compose snippet is broken. It is supposed to be fixed and if I look to c33bb05, it "looks" fixed, but nevertheless is still displayed wrong |
Possibly adding a new line between
could help - but I'm not sure |
@JMoVS the docs have not been deployed since the fix. that is usually done every release. |
ah okay, then it makes sense ;-) |
1.) This PR removes the microbadger badge. It's not resolving, and the project is shutdown:
https://twitter.com/microscaling/status/1361054926399557644
https://web.archive.org/web/20210409135814/https://microbadger.com/shutdown
2.) Remove a trailing space. I think this is causing the snippet to now show up as expected on the quickstart guide with
image
andvolumes
being on the same line:3.) Adjusts the indentation of the docker-compose snippet