Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove broken badge and fix docker-compose snippet #1025

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

djquan
Copy link
Contributor

@djquan djquan commented Jul 18, 2021

1.) This PR removes the microbadger badge. It's not resolving, and the project is shutdown:

image

https://twitter.com/microscaling/status/1361054926399557644
https://web.archive.org/web/20210409135814/https://microbadger.com/shutdown

2.) Remove a trailing space. I think this is causing the snippet to now show up as expected on the quickstart guide with image and volumes being on the same line:

image

3.) Adjusts the indentation of the docker-compose snippet

@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #1025 (66b8c9e) into main (7221704) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   59.63%   59.63%           
=======================================
  Files          22       22           
  Lines        1412     1412           
=======================================
  Hits          842      842           
  Misses        500      500           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7221704...66b8c9e. Read the comment docs.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I actually thought we already had removed it...

@piksel piksel merged commit c33bb05 into containrrr:main Jul 29, 2021
@piksel
Copy link
Member

piksel commented Jul 29, 2021

@all-contributors add @djquan for doc

@allcontributors
Copy link
Contributor

@piksel

I've put up a pull request to add @djquan! 🎉

@JMoVS
Copy link

JMoVS commented Aug 31, 2021

Hi, on the webpage, the docker-compose snippet is broken. It is supposed to be fixed and if I look to c33bb05, it "looks" fixed, but nevertheless is still displayed wrong

@JMoVS
Copy link

JMoVS commented Aug 31, 2021

Possibly adding a new line between

=== "docker-compose.yml"
<new line here>
    ```yaml

could help - but I'm not sure

@piksel
Copy link
Member

piksel commented Sep 1, 2021

@JMoVS the docs have not been deployed since the fix. that is usually done every release.

@JMoVS
Copy link

JMoVS commented Sep 1, 2021

ah okay, then it makes sense ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants