Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: container client tests refactor #1117

Merged
merged 1 commit into from Nov 1, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 1, 2021

Refactoring of the container client tests.

  • The tests should now explicitly tell what they are testing for and the requirements
  • Fixed the test data so that it doesn't contain discrepancies
  • The mock client is now being fully reset between tests (no shared state) and only support the calls that is expected

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1117 (536035c) into main (2c86956) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1117   +/-   ##
=======================================
  Coverage   61.96%   61.96%           
=======================================
  Files          22       22           
  Lines        1438     1438           
=======================================
  Hits          891      891           
  Misses        463      463           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c86956...536035c. Read the comment docs.

@piksel piksel merged commit 1b405d4 into main Nov 1, 2021
@piksel piksel deleted the test/container-client-refac branch November 1, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant