Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve session result logging #1123

Merged
merged 1 commit into from Nov 18, 2021
Merged

feat: improve session result logging #1123

merged 1 commit into from Nov 18, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 4, 2021

  • logs the session result as an info level message without notification instead of debug
  • does not log that no notification was sent if there are no notifications enabled

Fixes #1122

- logs the session result as an info level message without notification instead of debug
- does not log that no notification was sent if there are no notifications enabled
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #1123 (50356ed) into main (4a66a69) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   61.96%   61.89%   -0.07%     
==========================================
  Files          22       22              
  Lines        1438     1438              
==========================================
- Hits          891      890       -1     
- Misses        463      464       +1     
  Partials       84       84              
Impacted Files Coverage Δ
pkg/notifications/shoutrrr.go 73.07% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a66a69...50356ed. Read the comment docs.

@simskij simskij merged commit 782529d into main Nov 18, 2021
@simskij simskij deleted the fix/notifyless-log branch November 18, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Finished" event to log after One-time run or otherwise
2 participants