Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): support delayed sending #1142

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Nov 23, 2021

Fixes #1135

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1142 (dd663c1) into main (b4a225c) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   61.81%   61.94%   +0.12%     
==========================================
  Files          23       23              
  Lines        1477     1482       +5     
==========================================
+ Hits          913      918       +5     
  Misses        478      478              
  Partials       86       86              
Impacted Files Coverage Δ
pkg/notifications/email.go 90.90% <100.00%> (+0.21%) ⬆️
pkg/notifications/notifier.go 72.00% <100.00%> (+1.78%) ⬆️
pkg/notifications/shoutrrr.go 73.41% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b45ab...dd663c1. Read the comment docs.

@piksel piksel marked this pull request as ready for review December 20, 2021 14:25
@piksel piksel requested a review from simskij as a code owner December 20, 2021 14:25
@piksel piksel changed the title support delaying notifications feat(notifications): support delayed sending Jan 5, 2022
@piksel piksel merged commit 1d59fb8 into main Jan 5, 2022
@piksel piksel deleted the fix/notification-delay branch January 5, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--notification-email-delay is ignored
2 participants