Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose syntax in quick-start. GH #1105 #1169

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

atombrella
Copy link
Contributor

@atombrella atombrella commented Dec 19, 2021

Result after my changes. Although the tabbed feature is not working for me locally.

docker-compose-volumes-watchtower

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #1169 (f58c1e3) into main (d2f1185) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          23       23           
  Lines        1475     1475           
=======================================
  Hits          913      913           
  Misses        476      476           
  Partials       86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f1185...f58c1e3. Read the comment docs.

@piksel
Copy link
Member

piksel commented Dec 20, 2021

Yeah, this will break the tabs. To preview it locally, you need to serve it using mkdocs serve (after installing the mkdocs-material theme):
https://squidfunk.github.io/mkdocs-material/getting-started/

I think this was caused by some auto-formatting...

@atombrella
Copy link
Contributor Author

atombrella commented Dec 20, 2021

Hmm, not even on main, the tabs are working, and some stuff under node_modules is not there. I looked in the workflow to see how to test locally for the docs.

@atombrella
Copy link
Contributor Author

INFO     -  [11:47:51] Browser connected: http://localhost:8000/watchtower/
WARNING  -  [11:47:52] "GET /node_modules/rxjs/src/internal/Observable.ts HTTP/1.1" code 404
WARNING  -  [11:47:52] "GET /node_modules/rxjs/src/internal/ReplaySubject.ts HTTP/1.1" code 404
INFO     -  [11:47:52] Browser connected: http://127.0.0.1:8000/watchtower/

@piksel
Copy link
Member

piksel commented Dec 20, 2021

@piksel
Copy link
Member

piksel commented Dec 20, 2021

Fixed the config to use the new tabs and added the correct indentation to have them grouped together:
image

@simskij
Copy link
Member

simskij commented Dec 27, 2021

I'll merge this as it's currently broken, thanks all for your contributions! With that said, I think we should get rid of the tabbed feature as it just makes the docs less digestible in favor of flair. 😅

@simskij simskij merged commit 2fa8a2a into containrrr:main Dec 27, 2021
@atombrella atombrella deleted the fix_documentation_1105 branch December 27, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants