Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information for metrics.md #1193

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

jamesmacwhite
Copy link
Contributor

It might be me, but I thought that the metrics.md documentation could do with directly mentioning the specific endpoint that the Prometheus metrics are provided at and also providing an example scrape_config for Prometheus usage, if not using the demo example.

I had to end up going through the GitHub repository to find this information, so I thought it might be a good idea to include in the docs directly.

Mention the specific endpoint and an example Promethes scrape_config.
@simskij simskij merged commit 8590d88 into containrrr:main Jan 20, 2022
@simskij
Copy link
Member

simskij commented Jan 20, 2022

Thank you for your contribution! 🎉
@all-contributors add @jamesmacwhite for docs

@allcontributors
Copy link
Contributor

@simskij

I've put up a pull request to add @jamesmacwhite! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants