Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0, 2.1] Bug when creating an attribute with the same column name #436

Closed
zonky2 opened this issue Dec 13, 2018 · 3 comments
Closed

[2.0, 2.1] Bug when creating an attribute with the same column name #436

zonky2 opened this issue Dec 13, 2018 · 3 comments
Assignees
@baumannsven
Labels
bug
Milestone
2.0.0

Comments

@zonky2
Copy link
Contributor

zonky2 commented Dec 13, 2018

see MetaModels/core#1255 (comment)
@zonky2 zonky2 added this to the 2.0.0 milestone Dec 13, 2018
@zonky2 zonky2 added the bug label Dec 13, 2018
@zonky2 zonky2 mentioned this issue Dec 13, 2018
Closed
@discordier
Copy link
Member

Bug got introduced in 17446f3#diff-74bdf77094b9a1246f922701deacb509R732
It does store the model with implicit id "null", however, the result is ignored here 17446f3#diff-11ce102fa1c0f4cff1dfd6be4d793231R71 and therefore we will never see the error.

Assigned to @baumannsven, as he developed it. Nothing we can do from MetaModel side.

@baumannsven
Copy link
Member

I have look this. By my test for 2.0 their throw an exception for when the column exists

@baumannsven
Copy link
Member

Fixed in 705efc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baumannsven baumannsven

Labels
bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@discordier @zonky2 @baumannsven