fix fclose error on failed connection

contao · Apr 3, 2017 · cfdbae5 · cfdbae5
1 parent f41c5e4
commit cfdbae5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/check/controller/installer.php b/check/controller/installer.php
@@ -110,10 +110,9 @@ protected function canInstall()
 	public function canConnect()
 	{
 		$connection = @fsockopen('ssl://download.contao.org', 443, $errno, $errstr, 10);
-		$connected = ($connection !== false);
-		fclose($connection);
 
-		if ($connected) {
+		if ($connection !== false) {
+			fclose($connection);
 			return true;
 		}
 

diff --git a/check/controller/live-update.php b/check/controller/live-update.php
@@ -194,10 +194,9 @@ public function isFastCgiEaccelerator()
 	public function canConnect()
 	{
 		$connection = @fsockopen('ssl://update.contao.org', 443, $errno, $errstr, 10);
-		$connected = ($connection !== false);
-		fclose($connection);
 
-		if ($connected) {
+		if ($connection !== false) {
+			fclose($connection);
 			return true;
 		}
 

diff --git a/check/controller/repository.php b/check/controller/repository.php
@@ -76,10 +76,9 @@ public function hasSsl()
 	public function canConnect()
 	{
 		$connection = @fsockopen('ssl://contao.org', 443, $errno, $errstr, 10);
-		$connected = ($connection !== false);
-		fclose($connection);
 
-		if ($connected) {
+		if ($connection !== false) {
+			fclose($connection);
 			return true;
 		}