-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conflict with twig 3.10.0 #69
Conversation
To be clear, this is the error that currently occurs during cache:warmup
|
This is causing it and would need a fix wherever the EscaperExtension is used https://github.com/twigphp/Twig/blob/bfc3b7b19be1d3411d5b9ada4091ec7eecd3dd8a/CHANGELOG#L13-L16 The following methods from
Use the same methods on the |
But deprecations do not cause critical errors, there must be another issue. |
Do we need to fix this in Contao? Or do we just have to wait until twigphp/Twig#4082 is fixed? |
There is a PR that aims at fixing the BC break. I did not check whether it fixes our issue as well, though. 🤞 |
|
Unfortunately there is a different issue now: twigphp/Twig#4087 |
The recently released twig version adds new deprecations:
twigphp/Twig@v3.9.3...v3.10.0