Remove the registerCommands() methods (see #1126)

Description ----------- Symfony 4.4 no longer auto-registers commands, therefore we do not have to override the method anymore. Commits ------- c24b446 Remove the registerCommands() methods
contao · Dec 23, 2019 · 385fc89 · 385fc89
1 parent 1aacab4
commit 385fc89
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 30 deletions.
diff --git a/core-bundle/src/ContaoCoreBundle.php b/core-bundle/src/ContaoCoreBundle.php
@@ -31,7 +31,6 @@
 use Contao\CoreBundle\Fragment\Reference\ContentElementReference;
 use Contao\CoreBundle\Fragment\Reference\FrontendModuleReference;
 use Symfony\Bundle\SecurityBundle\DependencyInjection\SecurityExtension;
-use Symfony\Component\Console\Application;
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
@@ -50,14 +49,6 @@ public function getContainerExtension(): ContaoCoreExtension
         return new ContaoCoreExtension();
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function registerCommands(Application $application): void
-    {
-        // disable automatic command registration
-    }
-
     /**
      * {@inheritdoc}
      */

diff --git a/core-bundle/tests/ContaoCoreBundleTest.php b/core-bundle/tests/ContaoCoreBundleTest.php
@@ -29,23 +29,11 @@
 use Contao\CoreBundle\DependencyInjection\Compiler\TranslationDataCollectorPass;
 use Contao\CoreBundle\DependencyInjection\Security\ContaoLoginFactory;
 use Symfony\Bundle\SecurityBundle\DependencyInjection\SecurityExtension;
-use Symfony\Component\Console\Application;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\DependencyInjection\FragmentRendererPass;
 
 class ContaoCoreBundleTest extends TestCase
 {
-    public function testDoesNotRegisterAnyCommands(): void
-    {
-        $application = new Application();
-        $commands = $application->all();
-
-        $bundle = new ContaoCoreBundle();
-        $bundle->registerCommands($application);
-
-        $this->assertSame($commands, $application->all());
-    }
-
     public function testAddsTheCompilerPaths(): void
     {
         $passes = [

diff --git a/manager-bundle/src/ContaoManagerBundle.php b/manager-bundle/src/ContaoManagerBundle.php
@@ -13,7 +13,6 @@
 namespace Contao\ManagerBundle;
 
 use Contao\ManagerBundle\DependencyInjection\Compiler\ContaoManagerPass;
-use Symfony\Component\Console\Application;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
@@ -28,12 +27,4 @@ public function build(ContainerBuilder $container): void
 
         $container->addCompilerPass(new ContaoManagerPass());
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function registerCommands(Application $application): void
-    {
-        // disable automatic command registration
-    }
 }