Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the registerCommands() methods #1126

Merged
merged 1 commit into from Dec 23, 2019
Merged

Remove the registerCommands() methods #1126

merged 1 commit into from Dec 23, 2019

Conversation

leofeyer
Copy link
Member

Symfony 4.4 no longer auto-registers commands, therefore we do not have to override the method anymore.

@leofeyer leofeyer added the bug label Dec 20, 2019
@leofeyer leofeyer added this to the 4.9 milestone Dec 20, 2019
@leofeyer leofeyer self-assigned this Dec 20, 2019
@leofeyer leofeyer merged commit 385fc89 into master Dec 23, 2019
@leofeyer leofeyer deleted the bugfix/command-registration branch December 23, 2019 10:09
@aschempp
Copy link
Member

aschempp commented Jan 4, 2020

Symfony 4.4 no longer auto-registers commands, therefore we do not have to override the method anymore.

Just to make this clear for anyone else, this was removed in Symfony 4.0 (not 4.4): symfony/symfony@cc1695c#diff-846731663848075801b9a0f89e19a8ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@Toflar Toflar Toflar approved these changes

@bytehead bytehead bytehead approved these changes

@aschempp aschempp Awaiting requested review from aschempp

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leofeyer @aschempp @ausi @Toflar @bytehead