Fix relative front end preview links (see #6843)

Description ----------- For relative links, the `Uri` host would be empty, therefore it would generate a link with `localhost` instead of just keeping the relative link. Commits ------- f6c66d8 Fix relative frontend preview links
contao · Feb 2, 2024 · cb3dde0 · cb3dde0
1 parent 28a9092
commit cb3dde0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/core-bundle/src/Controller/BackendPreviewController.php b/core-bundle/src/Controller/BackendPreviewController.php
@@ -80,7 +80,7 @@ public function __invoke(Request $request): Response
 
         $targetUri = new Uri($targetUrl);
 
-        if ($request->getHost() === $targetUri->getHost() || !($user = $this->security->getUser())) {
+        if (!$targetUri->getHost() || $request->getHost() === $targetUri->getHost() || !($user = $this->security->getUser())) {
             return new RedirectResponse($targetUrl);
         }
 

diff --git a/core-bundle/tests/Controller/BackendPreviewControllerTest.php b/core-bundle/tests/Controller/BackendPreviewControllerTest.php
@@ -200,6 +200,12 @@ public function redirectsFromPreviewUrlConvertEventListener(): \Generator
             'https://www.example.com/en/foo.html',
         ];
 
+        yield 'Redirect relative to front end' => [
+            'https://www.example.com/preview.php/contao/preview?page=17',
+            '/en/foo.html',
+            '/en/foo.html',
+        ];
+
         yield 'Redirects to login link URL for cross-domain previews' => [
             'https://www.example.com/preview.php/contao/preview?page=42',
             'https://www.example.org/en/foo.html',