Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative front end preview links #6843

Merged
merged 1 commit into from Feb 2, 2024
Merged

Fix relative front end preview links #6843

merged 1 commit into from Feb 2, 2024

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented Feb 2, 2024

For relative links, the Uri host would be empty, therefore it would generate a link with localhost instead of just keeping the relative link.

@aschempp aschempp added the bug label Feb 2, 2024
@aschempp aschempp added this to the 5.3 milestone Feb 2, 2024
@aschempp aschempp requested a review from a team February 2, 2024 09:50
@aschempp aschempp self-assigned this Feb 2, 2024
@leofeyer leofeyer changed the title Fix relative frontend preview links Fix relative front end preview links Feb 2, 2024
@leofeyer leofeyer merged commit cb3dde0 into contao:5.3 Feb 2, 2024
18 checks passed
@leofeyer
Copy link
Member

leofeyer commented Feb 2, 2024

Thank you @aschempp.

@aschempp aschempp deleted the fix/relative-preview branch February 2, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

Assignees

@aschempp aschempp

Labels
bug
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aschempp @leofeyer