Disable auto cache control of the Symfony SessionListener #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2019
leofeyer
approved these changes
Dec 2, 2019
|
Thank you @Toflar. |
|
Should we do this for everything? Or should we only do that for Contao requests? Also, I realize that this listener is in the contao-core bundle, so this is also applied to any regular Symfony application, not sure we can assume anything about caching and cookie whitelists there? |
|
I think it's not wrong in the core-bundle but it should probably check for |
leofeyer
pushed a commit
that referenced
this pull request
Dec 3, 2019
…iable (see #1034) Description ----------- While debugging #1033 I noticed that we cannot configure the trace level of `HttpCache`. It absolutely makes no sense to bind that to `$this->isDebug` because in our case, this is always the case when we are in `dev` mode which again disables the HttpCache completely. So here we go, by setting `TRACE_LEVEL=full` the `Contao-Cache` header gives you a lot more insight into the fragment requests. Commits ------- 64fe068 Allow to configure the HttpCache trace level using an environment variable
leofeyer
pushed a commit
to contao/manager-bundle
that referenced
this pull request
Dec 3, 2019
…iable (see #1034) Description ----------- While debugging contao/contao#1033 I noticed that we cannot configure the trace level of `HttpCache`. It absolutely makes no sense to bind that to `$this->isDebug` because in our case, this is always the case when we are in `dev` mode which again disables the HttpCache completely. So here we go, by setting `TRACE_LEVEL=full` the `Contao-Cache` header gives you a lot more insight into the fragment requests. Commits ------- 64fe0685 Allow to configure the HttpCache trace level using an environment variable
yes thats what I meant |
|
Add an issue then so we don't forget about it. |
|
See #1079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028.
In fact, we don't need the default behaviour of Symfony because we qualify for "advanced usage" and our listener already correctly handles making responses private if needed.
I thought we need session stacking but that's not required because the SessionListener of SF correctly closes the session during
kernel.finish_requestwhich will cause our listener to correctly determine that the session was not started yet during the nextkernel.response.