Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support existing htaccess without RewriteRule #160

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Nov 3, 2018

@aschempp
Copy link
Member

aschempp commented Nov 7, 2018

I generally like this, but I think the .htaccess file should just get a special handling, instead of some "inline and name check". Like just call a method to copy or append the .htaccess after all other skeleton files have been copied.

@leofeyer leofeyer merged commit df75a50 into contao:master Nov 15, 2018
@leofeyer
Copy link
Member

Thank you @Toflar.

@Toflar Toflar deleted the feature/support-existing-htaccess-without-rewriterule branch November 15, 2018 13:00
@Toflar
Copy link
Member Author

Toflar commented Nov 16, 2018

@leofeyer should we backport this to 4.4? It's not really a feature regarding how to use Contao. It's simplifying the installation of Contao and people will continue to install 4.4 until 2022 😄

@leofeyer
Copy link
Member

Backported in 254f8f7.

@leofeyer leofeyer modified the milestones: 4.7.0, 4.7 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants