New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the .htaccess already exist contao is not placing its own #70
Comments
I think that's a quite common case @contao/developers. If the .htaccess only contains |
I don't think merging an (That by the way is another reason why shipping that file is problematic / related disucssion: #58) |
I would do it only if |
Yeah, that would be fine then, I guess. We have to be careful, though. If something in the lines we're adding affects this php setting (and if it's presence is neccessary by the hoster), the server might e.g. deliver unparsed PHP. |
The |
I fully agree with this. We must not mess with an existing |
If you don't want to mess with an existing |
maybe it´s possible to write |
As discussed in Mumble on August 30th, we want to check the existing
and if there is no match, we want to append the .htaccess content. Additionally, we want to provide a |
PR ready: contao/contao#160 |
Thank you @Toflar. 👍 |
Description ----------- Implements contao/manager-bundle#70. Commits ------- 6ea8dbf Added support for already existing htaccess without existing RewriteRule directive 426f9af Encapsulate the .htaccess logic in a separate method
Description ----------- Implements #70. Commits ------- 6ea8dbfd Added support for already existing htaccess without existing RewriteRule directive 426f9af0 Encapsulate the .htaccess logic in a separate method
Some Webhoster are adding a
.htaccess
with anAddHandler
in the web-folder if you change the PHP version.For example:
AddHandler application/x-httpd-php72 .php
Is it possible to merge the AddHandler during the creation of the
.htaccess
and overwrite the old version.While testing the new Contao Manager everything went well, expect updating the database (domain.com/contao/install), while the needed lines in the .htaccess were missing.
The text was updated successfully, but these errors were encountered: