Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the symfony/monolog-bundle dependency from functional tests #1914

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Remove the symfony/monolog-bundle dependency from functional tests #1914

merged 1 commit into from
Jul 7, 2020

Conversation

bytehead
Copy link
Member

@bytehead bytehead commented Jul 7, 2020

Q A
Fixed issues Fixes contao/phpstan#18
Docs PR or issue n/a

The symfony/monolog-bundle is registered in the kernel for the functional tests and therefore creates a dependency which was removed in contao/phpstan in contao/phpstan@be3a203.

IMO this can be removed.

@bytehead bytehead self-assigned this Jul 7, 2020
@bytehead bytehead added the bug label Jul 7, 2020
@bytehead bytehead added this to the 4.9 milestone Jul 7, 2020
@leofeyer leofeyer merged commit 801429d into contao:4.9 Jul 7, 2020
@leofeyer
Copy link
Member

leofeyer commented Jul 7, 2020

Thank you @bytehead.

@bytehead bytehead deleted the fix/remove-monolog-bundle-dependency branch July 7, 2020 15:24
@bytehead bytehead mentioned this pull request Jul 7, 2020
Closed
@leofeyer leofeyer changed the title Remove symfony/monolog-bundle dependency from functional tests Remove the symfony/monolog-bundle dependency from functional tests Jul 9, 2020
@leofeyer leofeyer mentioned this pull request Jul 20, 2020
Merged
leofeyer added a commit that referenced this pull request Jul 20, 2020
@leofeyer
Revert 'Remove symfony/monolog-bundle dependency from functional test…
fcd0cfe 
…s' (see #1943)

Description
-----------

This reverts the changes from #1914 (see #1927).

Commits
-------

9b0f2b2 Revert 'Remove symfony/monolog-bundle dependency from functional tests'
1c2b034 Add a comment why the bundle is loaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp approved these changes

Assignees

@bytehead bytehead

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bytehead @leofeyer @aschempp