Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 'Remove symfony/monolog-bundle dependency from functional tests' #1943

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Revert 'Remove symfony/monolog-bundle dependency from functional tests' #1943

merged 2 commits into from
Jul 20, 2020

Conversation

leofeyer
Copy link
Member

This reverts the changes from #1914 (see #1927).

@leofeyer leofeyer added the bug label Jul 20, 2020
@leofeyer leofeyer added this to the 4.9 milestone Jul 20, 2020
@leofeyer leofeyer requested a review from a team July 20, 2020 08:38
@leofeyer leofeyer self-assigned this Jul 20, 2020
bytehead
bytehead previously approved these changes Jul 20, 2020
View reviewed changes
aschempp
aschempp previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could add a comment why the bundle is required?

@leofeyer leofeyer dismissed stale reviews from aschempp and bytehead via 1c2b034 July 20, 2020 08:56
@leofeyer leofeyer merged commit fcd0cfe into contao:4.9 Jul 20, 2020
@leofeyer leofeyer deleted the fix/functional-tests branch July 20, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytehead bytehead bytehead approved these changes

@aschempp aschempp Awaiting requested review from aschempp

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leofeyer @bytehead @aschempp