Fix the rgxp=>httpurl implementation #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
force-pushed
the
fix/http-url
branch
from
64a1e36
to
4519b2d
Compare
leofeyer
force-pushed
the
fix/http-url
branch
from
4519b2d
to
bdf66f7
Compare
|
I am in favour of constants for everything. Not sure where to put them though. |
fritzmg
approved these changes
Jan 29, 2021
AlexejKossmann
pushed a commit
to AlexejKossmann/contao
that referenced
this pull request
Apr 6, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes contao#2629 | Docs PR or issue | - This PR fixes the rgxp=>httpurl implementation, which was missing a couple of checks. It also uses the new rgxp for all fields that expect an absolute URL (see contao#2629). I am not a big fan of having class constants for 2 of 10 rgxp options, though. Either all or none. @contao/developers WDYT? Commits ------- bdf66f7 Fix the rgxp=>httpurl implementation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the rgxp=>httpurl implementation, which was missing a couple of checks. It also uses the new rgxp for all fields that expect an absolute URL (see #2629).
I am not a big fan of having class constants for 2 of 10 rgxp options, though. Either all or none. @contao/developers WDYT?