Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-regex values in the search filter #2735

Merged
merged 8 commits into from
Mar 3, 2021
Merged

Handle non-regex values in the search filter #2735

merged 8 commits into from
Mar 3, 2021

Conversation

ausi
Copy link
Member

@ausi ausi commented Feb 11, 2021

Q A
Fixed issues Fixes #2498 (comment)

@ausi ausi added the bug label Feb 11, 2021
@ausi ausi added this to the 4.9 milestone Feb 11, 2021
@ausi ausi self-assigned this Feb 11, 2021
@ausi ausi mentioned this pull request Feb 11, 2021
Closed
fritzmg
fritzmg previously approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦊

@leofeyer leofeyer linked an issue Feb 12, 2021 that may be closed by this pull request
Backend filter does not work when using special chars - brackets #2498
Closed
Toflar
Toflar previously approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦊

fritzmg
fritzmg previously approved these changes Feb 12, 2021
View reviewed changes
@ausi ausi dismissed stale reviews from fritzmg and Toflar via 692f47f February 12, 2021 09:54
@Toflar
Copy link
Member

Toflar commented Feb 12, 2021

Ah, don't we have the same issue in DC_Folder.

@leofeyer
Copy link
Member

Oh yes, we do. And in PageSelector and FileSelector.

@aschempp
Copy link
Member

The REPLACE is what I suggested, but didn't you argue this would break any database indexes?

@ausi
Copy link
Member Author

ausi commented Feb 15, 2021 •
edited
Loading

The REPLACE is what I suggested, but didn't you argue this would break any database indexes?

No, I answered that REGEXP doesn’t use the index anyway (unless you are matching from the start of the string, which we do not in this case).

aschempp
aschempp previously approved these changes Feb 22, 2021
View reviewed changes
@ausi
Copy link
Member Author

ausi commented Feb 24, 2021

Ah, don't we have the same issue in DC_Folder.

Oh yes, we do. And in PageSelector and FileSelector.

Done. This should be RTM now I think.

@leofeyer leofeyer changed the title Fix search filter fon non-regex values Handle non-regex values in the search filter Mar 3, 2021
@leofeyer leofeyer merged commit 74d391f into contao:4.9 Mar 3, 2021
@leofeyer
Copy link
Member

leofeyer commented Mar 3, 2021

Thank you @ausi.

@ausi ausi deleted the fix/regexp-search-filter branch December 3, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer left review comments

@Toflar Toflar Toflar approved these changes

@aschempp aschempp aschempp approved these changes

@fritzmg fritzmg fritzmg left review comments

Assignees

@ausi ausi

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Backend filter does not work when using special chars - brackets
5 participants
@ausi @Toflar @leofeyer @aschempp @fritzmg